692932 - Enable mozhghooks/commit-message.py on mozilla-central, feeder repos, and release branches

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Jesse Ruderman]

Please change DATE_HOOK_ENABLED to two days in the future and then enable mozhghooks/commit-message.py on mozilla-central, feeder repos, and release branches.

See http://groups.google.com/group/mozilla.dev.planning/browse_thread/thread/26b36800a8d4a8a1?pli=1 for the consensus behind this change, and bug 506949 for details.

Comment 1

[(no longer active)]

I'm not sure what feeder repos are, but we need this on mozilla-inbound.

Comment 2

[(not currently active) Ted Mielczarek]

I believe Jesse means "all branches that merge with mozilla-central", so inbound and all project branches.

Comment 3

[Corey Shields [:cshields]]

Dan is back next week, between he and Ben they should be able to get this figured out.  Any and all instructions you guys can provide for people who are not use to managing mercurial would speed this up.  Thanks

Comment 4

[Ben Kero [:bkero]]

I've figured out where this lives by reading the bug referenced in comment #0.  I'd like to coordinate with someone from build when adding this, so I don't mess it up.  I'll plan on doing this tomorrow.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/hgcustom/hghooks/file/e7d2ca6c9aee/mozhghooks/commit-message.py

    23 # Before enabling this hook on mozilla-central (and feeder repos), this should be
    24 # set to a date in the near future.
    25 DATE_HOOK_ENABLED = time.mktime(datetime.datetime(2011, 10, 01).timetuple()) # October 2011 (CHANGE ME)

Don't forget this.

Comment 6

[Jesse Ruderman]

http://groups.google.com/group/mozilla.dev.planning/browse_thread/thread/4e0eb1ecaecf002b

Comment 7

[Tom S [:evilpie]]

We still need to enable this hook on the feeder repos.

Comment 8

[Ben Kero [:bkero]]

This hook has been enabled on mozilla-mobile-5.0 (for testing), and now for mozilla-inbound, and went active today.

evilpie on irc said there was more bikeshedding on this implementation, and that it was recommended that I hold off that in deploying it until the discussion had resolved.

Comment 9

[Ben Kero [:bkero]]

For reference, the hook is held in /repo/hg/libraries/mozhghooks/commit-message.py and the reference in $REPO/.hg/hrc is:

pretxnchangegroup.c_commitmessage = python:mozhghooks.commit-message.hook

Comment 10

[Tom S [:evilpie]]

So from my understanding we enabled it everywhere, where wanted.