Closed
Bug 69304
Opened 23 years ago
Closed 23 years ago
not folding constants for TCF_COMPILING cases
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla0.9
People
(Reporter: shaver, Assigned: shaver)
Details
(Keywords: js1.5)
Attachments
(1 file)
622 bytes,
patch
|
Details | Diff | Splinter Review |
We don't fold constants in the TCF_COMPILING case, because of what looks like a typo in http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/js/src&command=DIFF&root=/cvsroot&file=jsparse.c&rev1=3.48&rev2=3.49#29 We probably want to fold constants on pn2, rather than pn. As sr= for that checkin, I feel shame. I'll attach the obvious patch for consideration.
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Comment 2•23 years ago
|
||
Thanks for catching this, late better than never! sr=brendan@mozilla.org. Jband, how about a quick r=? /be
Comment 3•23 years ago
|
||
r=jband
Assignee | ||
Comment 4•23 years ago
|
||
In the tree -- thanks, guys.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•