Closed Bug 69304 Opened 23 years ago Closed 23 years ago

not folding constants for TCF_COMPILING cases

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla0.9

People

(Reporter: shaver, Assigned: shaver)

Details

(Keywords: js1.5)

Attachments

(1 file)

We don't fold constants in the TCF_COMPILING case, because of what looks like a
typo in
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/js/src&command=DIFF&root=/cvsroot&file=jsparse.c&rev1=3.48&rev2=3.49#29

We probably want to fold constants on pn2, rather than pn.  As sr= for that
checkin, I feel shame.  I'll attach the obvious patch for consideration.
Status: NEW → ASSIGNED
Keywords: js1.5, patch, review
Target Milestone: --- → mozilla0.9
Thanks for catching this, late better than never!  sr=brendan@mozilla.org. 
Jband, how about a quick r=?

/be
r=jband
In the tree -- thanks, guys.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Marking Verified - 
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: