693100 - Lots of "warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]" with gcc 4.6.1

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Filing to get on record, especially as I'm not certain what should be done for the tracer ones...

/home/jwalden/moz/slots/js/src/jstracer.cpp: In function ‘JSBool js::PrintOnTrace(char*, uint32, double*)’:
/home/jwalden/moz/slots/js/src/jstracer.cpp:1020:38: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

/home/jwalden/moz/slots/js/src/jstracer.cpp: In member function ‘js::RecordingStatus js::TraceRecorder::createThis(JSObject&, nanojit::LIns*, nanojit::LIns**)’:
/home/jwalden/moz/slots/js/src/jstracer.cpp:13661:60: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

/home/jwalden/moz/slots/js/src/methodjit/MonoIC.cpp: In member function ‘bool CallCompiler::generateNativeStub()’:
/home/jwalden/moz/slots/js/src/methodjit/MonoIC.cpp:1031:70: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

/home/jwalden/moz/slots/js/src/methodjit/FastBuiltins.cpp: In member function ‘js::mjit::CompileStatus js::mjit::Compiler::compileArrayWithArgs(uint32)’:
/home/jwalden/moz/slots/js/src/methodjit/FastBuiltins.cpp:610:35: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

/home/jwalden/moz/slots/js/src/methodjit/InvokeHelpers.cpp: In function ‘void* js_InternalInterpret(void*, void*, void*, js::VMFrame&)’:
/home/jwalden/moz/slots/js/src/methodjit/InvokeHelpers.cpp:1439:34: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

/home/jwalden/moz/slots/js/src/methodjit/Compiler.cpp: In member function ‘bool js::mjit::Compiler::jsop_newinit()’:
/home/jwalden/moz/slots/js/src/methodjit/Compiler.cpp:6450:28: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

/home/jwalden/moz/slots/js/src/methodjit/Compiler.cpp: In member function ‘void js::mjit::Compiler::finishBarrier(const js::mjit::Compiler::BarrierState&, js::mjit::RejoinState, uint32)’:
/home/jwalden/moz/slots/js/src/methodjit/Compiler.cpp:7561:38: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 567516 [details] [diff] [review]
Patch

ImmIntPtr(int) should work too for ImmPtr((void*)int)

Comment 3

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b450f04e6134

with ImmIntPtr in a few places.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/b450f04e6134