693172 - Move all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache, and then merge the classes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

My understanding is that the long term plan is to wrapper cache everything.  This moves us further down that path.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This might be a good second or third bug for somebody who is interested in poking around the DOM.

Comment 2

[Edmund Wong (:ewong)]

Attachment: Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes.

Comment 3

[Edmund Wong (:ewong)]

Attachment: Moved all subclasses of nsDOMEventTargetWrapperCache to nsDOMEventTargetHelper and merged the classes.

Over irc, khuey suggested I move the subclasses of nsDOMEventTargetWrapperCache to nsDOMEventTargetHelper and then merge the two classes.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 584538 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetWrapperCache to nsDOMEventTargetHelper and merged the classes.

Looks pretty good to me.  Going to toss it over to smaug for the official review though, since he owns event handling.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 584538 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetWrapperCache to nsDOMEventTargetHelper and merged the classes.

Looks ok, but I think there has been some changes to this code so could you
update the patch.

Comment 6

[Edmund Wong (:ewong)]

Attachment: Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes. (v2)

Comment 7

[Edmund Wong (:ewong)]

Attachment: Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes. (v3)

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 586987 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes. (v3)

This makes the hg annotation messy. Could you just update the previous
patch to contain the changes done to the nsDOMEventTargetWrapperCache
so that the code is copied to nsDOMEventTargetHelper

Comment 9

[Edmund Wong (:ewong)]

Attachment: Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes. (v4)

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 588007 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes. (v4)

You're not moving the cycle collection related parts for *Cache to the
*Helper.

Comment 11

[Edmund Wong (:ewong)]

Attachment: Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes. (v5)

Comment 12

[Edmund Wong (:ewong)]

Attachment: Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes. (v6)

Unbitrotted patch.

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bc6a70cdc0e7

Comment 14

[Olli Pettay [:smaug][[e-mail]]]

Um, did this cause leaks. I'm seeing lots of XHR objects in my CC graph.

Comment 15

[Olli Pettay [:smaug][[e-mail]]]

Though, could be also this horrible network connection and tons of tbpl tabs open.
Investigating.