Closed
Bug 693282
Opened 13 years ago
Closed 13 years ago
BasicShadowableThebesLayer leaking backBuffers
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
Attachments
(1 file)
3.05 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
Found that in 690469 I dropped BasicManager()->DestroyedThebesBuffer(BasicManager()->Hold(this), mBackBuffer); which was collecting dying buffers and deallocating it. Looks like that part need to be moved back, otherwise we are leaking thebes buffers
Assignee | ||
Comment 1•13 years ago
|
||
This fix looks OK, but why wasn't the leak caught by any of our tests? Were buffers actually leaking during reftest-ipc but not being caught, or do none of our tests exercise the path that was leading to a leak? We need to make sure this doesn't happen again.
Assignee | ||
Comment 3•13 years ago
|
||
yep, that is interesting question... that leak is very easily visible in about:memory reporter.... but reason is that we don't run IPC-reftests on debug linux builds... only on opt builds... that is why we don't run leak enabled test-run...
Sigh. Filed bug 693478.
Updated•13 years ago
|
Attachment #565907 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Comment 5•13 years ago
|
||
This patch need to be landed in couple with patch from bug 690469 in order 1-st bug 690469, second 693282
Keywords: checkin-needed
Comment 6•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd148629d7e7
Keywords: checkin-needed
Target Milestone: --- → mozilla10
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cd148629d7e7
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•