Closed Bug 693364 Opened 13 years ago Closed 13 years ago

Leak in CompartmentPrivate::RegisterDOMExpandoObject

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: Ms2ger, Assigned: peterv)

References

Details

Attachments

(1 file)

Attached patch v1Splinter Review
Assignee: nobody → peterv
Status: NEW → ASSIGNED
Attachment #566534 - Flags: review?(Ms2ger)
Comment on attachment 566534 [details] [diff] [review]
v1

>--- a/js/src/xpconnect/src/xpcprivate.h
>+++ b/js/src/xpconnect/src/xpcprivate.h
>     bool RegisterExpandoObject(XPCWrappedNative *wn, JSObject *expando) {
>         if (!expandoMap) {
>             expandoMap = new nsDataHashtable<nsPtrHashKey<XPCWrappedNative>, JSObject *>();
>             if (!expandoMap->Init(8))
>+            {

{ on the same line, as above, please.

r=me, for what that's worth.
Attachment #566534 - Flags: review?(Ms2ger) → review+
https://hg.mozilla.org/mozilla-central/rev/fd296c912d24
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: