Closed
Bug 693393
Opened 13 years ago
Closed 13 years ago
Improve poor man's Maybe<AutoCompartment> in JSAutoEnterCompartment.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: justin.lebar+bug, Unassigned)
References
Details
(Whiteboard: [iOS])
Attachments
(1 file)
|
1.44 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
We currently size the storage inside JSAutoEnterCompartment based on a platform-specific guess. This broke ted's iOS port, and it's ugly. We may be able to rely on the fact (?) that 32-bit systems with alignof(uint64) == 4 have 13-word AutoCompartments, while 32-bit systems with alignof(uint64) == 8 have 16-word AutoCompartments.
|
Reporter | |
Comment 1•13 years ago
|
||
|
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 565995 [details] [diff] [review] Patch v1 I think this works.
Attachment #565995 -
Flags: review?(luke)
|
||
Updated•13 years ago
|
Attachment #565995 -
Flags: review?(luke) → review+
|
|
Reporter | |
Comment 3•13 years ago
|
||
Thanks, Luke. https://hg.mozilla.org/integration/mozilla-inbound/rev/962683b9d15a
Whiteboard: [inbound]
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/962683b9d15a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
|
||
Updated•13 years ago
|
Whiteboard: [inbound] → [inbound][iOS]
|
|
Reporter | |
Updated•13 years ago
|
Whiteboard: [inbound][iOS] → [iOS]
|
||
Comment 6•13 years ago
|
||
Just for interest in case this dings other arches, on PPC this turned out to be 15 bytes, for some reason.
|
|
||
Comment 7•13 years ago
|
||
s/bytes/words/
You need to log in
before you can comment on or make changes to this bug.
Description
•