Closed
Bug 693609
Opened 13 years ago
Closed 13 years ago
IonMonkey: Share ValueOperand manipulation.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: nbp, Assigned: nbp)
Details
Attachments
(1 file, 1 obsolete file)
7.81 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
Due to different register size, the current method used for manipulating Value is dependent on the architecture. This implies that Trampoline code for x86/x64 is architecture where most of it could be shared. In this issue I suggest to foster usage of ValueOperand and manipulation of ValueOperand instead of *_Type & *_Data (for x86) or specific moves. Adding such features will reduce the effort needed for maintaining or extending operations on all architecture by reducing the base code. This should not impact at run-time because sharing function interfaces without making the function virtual in the specific macro-assemblers imply that functions would be either inlined or at worst statically linked.
Assignee | ||
Comment 1•13 years ago
|
||
Comment on attachment 566227 [details] [diff] [review] Simply manipulation of Values Review of attachment 566227 [details] [diff] [review]: ----------------------------------------------------------------- Functions that take Operand and ValueOperand should take them as const ... &, r=me with that
Attachment #566227 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Update. (old patch: r=dvander)
Attachment #566227 -
Attachment is obsolete: true
Attachment #567761 -
Flags: review+
http://hg.mozilla.org/projects/ionmonkey/rev/a9881c4374e7
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•