693686 - PGO talos is submitting to the Firefox-Non-PGO tree

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Armen [:armenzg]]

This is a fallout from bug 658313.

If we look at this:
https://tbpl.mozilla.org/?jobname=pgo
we can grab a Windows talos tp log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=6786954&tree=Firefox&full=1
we can see that tp5_shutdown_paint posted to Firefox-Non-PGO:
http://graphs.mozilla.org/graph.html#tests=[[128,94,496]]

This affects Fedora12, Fedora12x64, Win7 and WinXp.

We have to fix the branch name:
> 'python' 'PerfConfigurator.py' '-v' '-e' '../firefox/firefox' '-t' 'talos-r3-w7-034' '-b' '1.9.2' '--branchName' 'Firefox-Non-PGO' '--resultsServer' 'graphs.mozilla.org' '--resultsLink' '/server/collect.cgi' '--activeTests' 'tp5' '--mozAfterPaint' '--symbolsPath' '../symbols'

Comment 1

[Armen [:armenzg]]

Attachment: PGO builds should post to $branch rather than $branch-Non-PGO

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 566268 [details] [diff] [review]
PGO builds should post to $branch rather than $branch-Non-PGO

We should be looking at branchConfig['add_pgo_builders'] instead.  I have a patch that fixes this issue, will post it shortly.

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: another idea

Before removing my printf debugging lines, some sample output.  MozillaTest is the talos branch we use for all staging test runs.


Rev3 WINNT 5.1 mozilla-1.9.2 talos tp4 - MozillaTest
Rev3 WINNT 5.1 mozilla-inbound talos tp - MozillaTest-Non-PGO
Rev3 WINNT 5.1 mozilla-inbound pgo talos tp - MozillaTest
Rev3 WINNT 5.1 build-system talos tp - MozillaTest

Comment 4

[Armen [:armenzg]]

Comment on attachment 566310 [details] [diff] [review]
another idea

Review of attachment 566310 [details] [diff] [review]:
-----------------------------------------------------------------

This is good. I was already trying this same approach but I was not being able to make the output match what I wanted. I probably was doing something wrong.

Feel free to land it any time. I can do a reconfig in the morning if it doesn't happen today.

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

Ok, i'll land it now.  Thanks for doing the reconfig!

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 566310 [details] [diff] [review]
another idea

http://hg.mozilla.org/build/buildbotcustom/rev/f71f88ea9719

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Masters have been reconfig'd with this change.

Comment 8

[Armen [:armenzg]]

This hasn't worked:
| Rev3 Fedora 12 mozilla-central pgo talos tp on 2011-10-12 04:02:57 PDT for push e0ae39a3298e
| python PerfConfigurator.py -v -e ../firefox/firefox-bin -t talos-r3-fed-009 -b 1.9.2 --branchName Firefox-Non-PGO --resultsServer graphs.mozilla.org --resultsLink /server/collect.cgi --activeTests tp5 --mozAfterPaint --symbolsPath ../symbols

Comment 9

[Armen [:armenzg]]

Attachment: use pgo_factory

Comment 10

[Armen [:armenzg]]

This is now fixed:
http://graphs-new.mozilla.org/graph.html#tests=[[115,1,1],[115,1,14],[115,1,12],[115,1,15]]&sel=none&displayrange=7&datatype=running