693691 - Only list free webapps/add-ons in the dropdown box for upsell settings

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P4)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://addons-dev.allizom.org/en-US/developers/addon/app-337450/payments/3
2. Notice the options available in the dropdown menu.

expected behavior:
Only free webapps are listed.

actual behavior:
paid webapps and add-ons are listed.

Comment 1

[Andy McKay]

Can't reproduce yet, locally on -dev and in tests only free addons are shown.

Comment 2

[krupa raj[:krupa]]

I see this http://screencast.com/t/Nmkp8FuaSh.

Andy, do you have disabled add-ons/paid webapps associated with the same account?

Comment 3

[krupa raj[:krupa]]

I can link mark an add-on as upsell to an app which seems wrong.

Comment 4

[Wil Clouser [:clouserw]]

Is this a dupe of bug 679824?

Comment 5

[krupa raj[:krupa]]

Nope. This bug is about free apps and add-ons-> We shouldn't be listing premium or disabled add-ons/apps in upsell dropdown. The other bug is about not listing add-ons with contributions.

Comment 6

[krupa raj[:krupa]]

Note https://apps-preview-dev.allizom.org/en-US/apps/app/goofy/?src=cb-dl-home is marked as upsell for "DuckSauce" when both are premium apps. This seems bad. Is this bug still P4?

Comment 7

[krupa raj[:krupa]]

Attachment: screenshot

Comment 8

[Wil Clouser [:clouserw]]

(In reply to krupa raj 82[:krupa] from comment #6)
> Note
> https://apps-preview-dev.allizom.org/en-US/apps/app/goofy/?src=cb-dl-home is
> marked as upsell for "DuckSauce" when both are premium apps. This seems bad.
> Is this bug still P4?

If no one else can reproduce it, yeah.

Comment 9

[Andy McKay]

The only way I can reproduce this is by making an addon the target of an upsell and then making that addon premium. Will stop this.

Comment 10

[Andy McKay]

https://github.com/mozilla/zamboni/commit/9b8365