Closed
Bug 693996
Opened 13 years ago
Closed 13 years ago
Errors when switching scripts in the debugger
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: past, Assigned: past)
References
Details
Attachments
(1 file, 1 obsolete file)
7.02 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
Switching the displayed script in the editor does not seem to work currently: JavaScript error: chrome://browser/content/debugger/debugger.js, line 328: aScript is null This is a regression.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → past
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•13 years ago
|
||
Got it. It was a typo and a property vs. attribute issue. Plus a tiny fix for caching the script contents.
Attachment #566540 -
Flags: review?(dcamp)
Comment 2•13 years ago
|
||
Comment on attachment 566540 [details] [diff] [review] Working patch We should have test coverage for switching sources, r-'ing for that.
Attachment #566540 -
Flags: review?(dcamp) → review-
Assignee | ||
Comment 3•13 years ago
|
||
Added tests for changing the selected script in both paused and running states.
Attachment #566540 -
Attachment is obsolete: true
Attachment #567762 -
Flags: review?(dcamp)
Updated•13 years ago
|
Attachment #567762 -
Flags: review?(dcamp) → review+
Assignee | ||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/38c048a9a8ec
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•