69418 - Search: Single match displays text "1 matches found"

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[laurel]

Using feb19 commercial trunk build

The display text for a single search result is "1 matches found".  The text
should be singular "1 match found".

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Patch, please review.

Comment 2

[gayatrib]

Thank you Stephend. The patch looks great, except that the indentation for 
gStatusFeedback.showProgress(100) is changed in the patch. With that corrected, 
r=gayatrib

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Attachment: New patch, fixes my broken spacing and corrects a string.

Comment 4

[Peter "jag" Annema]

If you look a bit closer it looks like you're indenting using hard tabs where
the rest of the code uses 8 spaces. Please fix that :-) (Read the patch in
netscape/mozilla to see what I mean)

With that, r=jag (and r=gayatrib I guess).

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Hopefully this fixed tabbing foo!

Comment 6

[Peter "jag" Annema]

D'oh! I got distracted. I think it would be better to not do string building
like this in JS, but rather change the properties to read:
%S matches found
1 match found
and then use FormatStringFromName for the != 1 case.

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

http://bugzilla.mozilla.org/show_bug.cgi?id=69418

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Bah, silly cut and paste error on that last comment.  Gayatrib, you had better
take this one out from here ;-)  Sorry I couldn't do more, guys ;(

Comment 9

[Peter "jag" Annema]

Actually, r=jag on the patch as is, but let's open a new bug on fixing the
i18n/l10n problem here.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Seth, could you plant the wonderful two letters I like to see from you so much?
Thanks.

Comment 11

[Peter "jag" Annema]

Attachment: [patch] No, but this did

Comment 12

[Peter "jag" Annema]

I should have looked, I should have looked ...

Comment 13

[Blake Ross]

Attachment: [patch] use FormatStringFromName

Comment 14

[(not reading, please use [e-mail] instead)]

gayatrib / jag, will you test / review out blake's patch?

it looks correct.  once we get a r=, I'll do the super review.

Comment 15

[Peter "jag" Annema]

-            statusMsg = gNumOfSearchHits+"
"+Bundle.GetStringFromName("searchSuccessMessage");
+            statusMsg = FormatStringFromName("searchSuccessMessages",
[gNumOfSearchHits], 1);

That's missing |Bundle.|

Comment 16

[Blake Ross]

Attachment: [patch] it sure is

Comment 17

[Peter "jag" Annema]

I like this :-)

Of course, mao will kill you for merge hell ;-)

r=jag

Comment 18

[Blake Ross]

Seth, sr?

Comment 19

[(not reading, please use [e-mail] instead)]

gayatrib is the module owner for the search FE.

gayatrib, will you review this?

Comment 20

[gayatrib]

I had reviewed this before and had problem with bugzilla when i tried to commit 
my review. Sorry about the delay...
r=gayatrib

Comment 21

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 22

[Blake Ross]

Checked in.

Comment 23

[laurel]

OK using feb26 commercial trunk builds: linux rh6.0, mac OS 9.0, win98