Closed
Bug 694641
Opened 13 years ago
Closed 6 years ago
[nanojit] PPC broken in tamarin-redux (and likely nanojit-central)
Categories
(Tamarin Graveyard :: Virtual Machine, defect, P1)
Tracking
(Not tracked)
RESOLVED
WONTFIX
Q1 12 - Brannan
People
(Reporter: rreitmai, Assigned: rreitmai)
Details
(Whiteboard: wanted-standalone-js, fixed-in-nanojit, fixed-in-tamarin)
Attachments
(1 file, 1 obsolete file)
7.59 KB,
patch
|
spectre
:
review+
|
Details | Diff | Splinter Review |
As a result of landing the patches associated with bug 624164, I have most likely broken PPC builds. I'll attach the patches sent by Virgil to this bug in case anyone want to pick up where he left off, to ensure that PPC is functioning.
Assignee | ||
Comment 1•13 years ago
|
||
Comment 2•13 years ago
|
||
Strange. Why would those be needed? Also, I don't see the logic where asm_label() turns off swapping still: void Assembler::asm_label() { - // do nothing right now + // disable swapping for the next instruction; it's a branch point. + _lastOpcode.reg1 = NoSwap; }
Assignee | ||
Comment 3•13 years ago
|
||
Im(In reply to Cameron Kaiser from comment #2) > Strange. Why would those be needed? I'm not sure...he mentioned using xcode compiling 64b ppc. > Also, I don't see the logic where asm_label() turns off swapping still: > > void Assembler::asm_label() { > - // do nothing right now > + // disable swapping for the next instruction; it's a branch point. > + _lastOpcode.reg1 = NoSwap; > } I think this is the bit that was removed when I landed the patches en masse. If you're up to it and can tweak virgils patch, I can review and land it.
Updated•13 years ago
|
Whiteboard: wanted-standalone-js
Comment 4•13 years ago
|
||
This blocks normal Mac development and testing (Xcode builds normally build PPC). Please fix this with the utmost urgency or back out the broken assembler changes. (Backing out changesets 6641 and 6642 results in code that compiles and passes acceptance testing.)
Assignee: nobody → rreitmai
Severity: normal → blocker
Priority: -- → P1
Hardware: PowerPC → All
Target Milestone: --- → Q1 12 - Brannan
Comment 5•13 years ago
|
||
changeset: 6655:50b5a11cbd14 user: Lars T Hansen <lhansen@adobe.com> summary: For 694641: disabled PPC builds in Xcode project (r=lhansen) http://hg.mozilla.org/tamarin-redux/rev/50b5a11cbd14
Comment 6•13 years ago
|
||
The 64 bit code is not tested much so that could be it (comment 3). I'm looking at that segment, but I have no objection to backing it out until then.
Assignee | ||
Comment 7•13 years ago
|
||
virgils' patch + add back missing asm_label() code. Compiles on xcode both 32/64.
Attachment #567157 -
Attachment is obsolete: true
Attachment #567550 -
Flags: review?(spectre)
Assignee | ||
Comment 8•13 years ago
|
||
(In reply to Lars T Hansen from comment #4) > This blocks normal Mac development and testing The tamarin build system no longer performs ppc builds; disabling ppc in the xcode project is the most straightforward option, as per your comment 5.
Comment 9•13 years ago
|
||
Comment on attachment 567550 [details] [diff] [review] fixup ppc Beat me to it :) This looks okay. If I find any fallout in TenFourFox I'll submit a separate bug but we don't use the 64-bit stuff, so I don't think there will be any problem.
Attachment #567550 -
Flags: review?(spectre) → review+
Assignee | ||
Comment 10•13 years ago
|
||
rreitmai http://hg.mozilla.org/projects/nanojit-central/rev/19b6e1d68ea6
Whiteboard: wanted-standalone-js → wanted-standalone-js,fixed-in-nanojit
Assignee | ||
Updated•13 years ago
|
Severity: blocker → normal
Comment 11•13 years ago
|
||
changeset: 6734:60a467992d8b user: Rick Reitmaier <rreitmai> summary: Bug 694641 - [nanojit] PPC broken in tamarin-redux (and likely nanojit-central) (r=spectre) http://hg.mozilla.org/tamarin-redux/rev/60a467992d8b
Updated•13 years ago
|
Whiteboard: wanted-standalone-js,fixed-in-nanojit → wanted-standalone-js, fixed-in-nanojit, fixed-in-tamarin
Comment 12•6 years ago
|
||
Tamarin is a dead project now. Mass WONTFIX.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Comment 13•6 years ago
|
||
Tamarin isn't maintained anymore. WONTFIX remaining bugs.
You need to log in
before you can comment on or make changes to this bug.
Description
•