69469 - do {} while (PR_FALSE); seems rewritable

Status: RESOLVED INCOMPLETE

(Core :: Layout, defect)

Comment 1

[timeless]

Attachment: clean out do while loop

Comment 2

[timeless]

Attachment: better patch

Comment 3

[Christopher Blizzard (:blizzard)]

My only concern here is that it changes the flow of code, using returns instead
of breaks.  The do {} while(PR_FALSE) is being used here as a poor man's
exception routine.  A goto might work just as well if you want to skip ahead in
the case of a failure.

In any case, I'm not sure what the effect of the change in flow will be because
I can't see the surrounding code.  Waterson, layout is your favorite playground.
 Want to have a look?

Comment 4

[Chris Waterson]

Why is this better?

Comment 5

[Simon Fraser [no longer active]]

> A goto might work just as well if you want to skip ahead in the case of a failure.

Please don't use gotos to skip over code that contains nsCOMPtrs, or other C++
isms. You'll get compiler warnings at best, or crash at worst.

Comment 6

[timeless]

it took me a long time to understand what the while loop's purpose was.  early 
returns otoh are easily understood. [i'll attach a new patch w/ more cleanup]

Comment 7

[Brendan Eich [:brendan]]

timeless, why are you working on bugs that are way past mozilla1.0 in any
conceivable setting of their Target Milestones?  Please help with the crucial stuff.

/be

Comment 8

[Brendan Eich [:brendan]]

I misread the year in that date on timeless's last comment -- timeless, please
accept my apologies.  Sorry about that, I have something of a hair trigger
around you on 1.0 non-priorities and I just shot my own foot!

/be

Comment 9

[Christopher Hoess (gone)]

->misc code