695165 - Forward

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I can put in the plumbing for this pending UX mockups.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: (1/3) Minor cleanup in Tab.java

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: (2/3) Plumbing for Forward

I found this led to much simpler code than turning mHistory into a list and keeping an index pointer. That approach has lots of corner cases when the list is empty, or the index is out of bounds.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: (3/3) Hook up forward as menu item

Making this a separate change so that it can be backed out if UX changes without affecting the plumbing part.

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 569987 [details] [diff] [review]
(2/3) Plumbing for Forward

Is there a reason for using 2 stacks? We need to pop from one and push into another. Why not have a List<HistoryEntry> and use an index variable? That operation is faster I guess.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 569986 [details] [diff] [review]
(1/3) Minor cleanup in Tab.java

Moved this patch to 697732, since those patches need to go in first.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: (1/2) Add plumbing for forward

This patch applies on top of the ones from bug 695165

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: (2/2) Hook up forward as menu item

Rebased the old patch, but no functional changes.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Drive-by:

* Could we change "session-*" messages to "Session:*" ?

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: (3/2) Rename events for consistency

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 570252 [details] [diff] [review]
(3/2) Rename events for consistency

Thanks

Comment 12

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/projects/birch/rev/21fd85f89ad9
https://hg.mozilla.org/projects/birch/rev/7f8a9ba22b10
https://hg.mozilla.org/projects/birch/rev/591ac51b8359

Comment 13

[Aaron Train [:aaronmt]]

20111031103218
http://hg.mozilla.org/projects/birch/rev/9f5570d58bca
Samsung Galaxy SII (Android 2.3.4)