695549 - Rename everything in the front end

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

The front end is old. It has a lot of names like JSParseNode and JSStmtInfo that should be js::ParseNode and js::StmtInfo.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Part 1, rename types and put enums into namespace js - v1

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Part 2, move emitter global functions into namespace js::frontend - v1

js_PopStatement became js::frontend::PopStatementTC rather than js::frontend::PopStatement, because there is already a function named PopStatement, and that one is actually called rather more than this one.

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: Part 3, move tokenizer global functions into namespace js

It is subjective whether js or js::frontend is better. These functions (at least js_IsIdentifier) actually are used outside of the frontend/ subdirectory.

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: Part 4, rename js::Compiler to js::BytecodeCompiler

Elective surgery. I want to rename it to match the filename. (methodjit has a class js::mjit::Compiler. No collision.)

While I was in here I grepped for places where the old filenames jsscan, jsparse, jsemit were still used, so this patch fixes several of those (and deletes some bafflingly ancient super-dead code).

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 567919 [details] [diff] [review]
Part 1, rename types and put enums into namespace js - v1

I like it all.

Comment 6

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/318083d40e1c
https://hg.mozilla.org/integration/mozilla-inbound/rev/39cbf5aa4c4c
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c151e4cc979
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4bd037eb252

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/318083d40e1c
https://hg.mozilla.org/mozilla-central/rev/39cbf5aa4c4c
https://hg.mozilla.org/mozilla-central/rev/1c151e4cc979
https://hg.mozilla.org/mozilla-central/rev/a4bd037eb252