Closed Bug 696022 Opened 13 years ago Closed 10 years ago

pushlog shouldn't depend on simplejson anymore, and use json if possible

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Product:
Developer Services
Component:
Mercurial: hg.mozilla.org
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1074491

People

(Reporter: Pike, Unassigned)

Details

Attachments

(1 file)

Patch to make simplejson dep optional
2.56 KB, patch
Details | Diff | Splinter Review 
Right now, you have to have simplejson to use pushlog, which is sad given that current python's can do without it perfectly with their own json support.
Can you check this? It seems to pass most of the tests for me, but I have some problems because my hg is too modern for the templates (bug 666870).
Comment on attachment 568352 [details] [diff] [review]
Patch to make simplejson dep optional

My untested patch looks similar, I'd try builtin json before simplejson, though.

I'll do a real look later.
The signoff view passes the from/to in the wrong order.
(wrong bug)
Product: mozilla.org → Release Engineering
Isn't this a duplicate of bug 800557?
Product: Release Engineering → Developer Services
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/116]
This was done as part of bug 1074491.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/116]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: