696181 - Properties disabled in the css rule view should not be lost

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Description

[Dave Camp (:dcamp)]

1) Highlight node A
2) Disable a css property
3) Highlight node B
4) Highlight node A

The disabled css property is gone.  It should still be available.

Comment 1

[Dave Camp (:dcamp)]

Attachment: WIP 1

Attached patch saves disabled properties in the inspector store, but the inspector store doesn't last the lifetime of the window, just as long as the store.

Still needs tests.

Comment 2

[Dave Camp (:dcamp)]

Would it make sense for the inspector store to have page-lifetime instead of inspector-is-open lifetime?

Comment 3

[Rob Campbell [:rc] (:robcee)]

the InspectorStore's used to restore the Highlighter state on tab switch. I guess it currently has an "inspector-is-open lifetime". Changing that to page-lifetime might get a bit weird and might change some of the restore behavior.

That feels like it could add a fair bit of complexity to managing the InspectorStore. I'd have to see an implementation, I guess.

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 572121 [details] [diff] [review]
WIP 1

looking good.

Comment 5

[Dave Camp (:dcamp)]

Attachment: v1

Adds a (somewhat grody) test.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 572379 [details] [diff] [review]
v1

looks good. As for the test, I've seen grodier.

Comment 7

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/c465f6d67aa9

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/c465f6d67aa9