Closed Bug 69625 Opened 24 years ago Closed 23 years ago

[static ctor]static constructor in nsFSDR.cpp

Categories

(Core Graveyard :: Security: UI, defect)

Product:
Core Graveyard
Component:
Security: UI
Version:
1.0 Branch
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED WONTFIX

People

(Reporter: dbaron, Assigned: dbaron)

Details

in extensions/psm-glue/src/nsFSDR.cpp there is a global variable

nsAutoString gKey;

This causes static construction, which is bad because it causes portability
problems on some platforms (e.g., OpenBSD) and also leads to shutdown ordering
issues.  See <URL: http://www.mozilla.org/hacking/portable-cpp.html >.  (This
should also be an nsString rather than an nsAutoString.)
Reporter, is this still a problem now that PSM 2.0 is integrated into the 
nightly builds?
Not if extensions/psm-glue/ isn't built anymore, although I'd like to see the
file cvs removed before closing it, and also like to check that the code wasn't
just copied elsewhere.
psm-glue is no longer built. Marking WONTFIX.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
Verified per dddrinan's comments.
Status: RESOLVED → VERIFIED
Mass changing Security:Crypto to PSM
Component: Security: Crypto → Client Library
Product: Browser → PSM
Version: other → 2.1
Mass changing Security:Crypto to PSM
Product: PSM → Core
Version: psm2.1 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.