696398 - Need an api to analyze panning performance

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[(dormant account)]

We need to Start() and Stop() a panning operation. Once stopped we should get a histogram of paint times.

Comment 1

[cmtalbert]

Joel, this is the bug I mentioned where we were talking about a low level API to help measure panning for Fennec-native.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

would we need a separate bug for zooming?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

can I get an idea of what this API will look like and what I could expect from it?  Maybe just some example code of how to use it and some made up (yet moderately realistic) results?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

can we get this sample data?  we are building tools around this and it would be nice to work with some sample data.  Thanks!

Comment 5

[Jeff Muizelaar [:jrmuizel]]

I'll try to get this working this week.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: A sketch of what this would look like

This adds a startFrameTimeRecording() and stopFrameTimeRecording() to DOMWindowUtils. stopFrameTimeRecording() returns an array of frame times in milliseconds.

Comment 7

[cmtalbert]

I was talking with :pcwalton about this last night and he was worried that on birch, gecko might not have access to what's being drawn now as a result of the patch queue he landed last night (on birch).  Can you guys confirm whether or not that is the case?

Comment 8

[Jeff Muizelaar [:jrmuizel]]

(In reply to Clint Talbert ( :ctalbert ) from comment #7)
> I was talking with :pcwalton about this last night and he was worried that
> on birch, gecko might not have access to what's being drawn now as a result
> of the patch queue he landed last night (on birch).  Can you guys confirm
> whether or not that is the case?

Correct. Something like this API will need to be added to the Java UI.

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Attachment: Add the api

Comment 10

[Benoit Girard (:BenWa)]

Comment on attachment 577793 [details] [diff] [review]
Add the api

Review of attachment 577793 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/Layers.cpp
@@ +576,5 @@
> +
> +nsTArray<float>
> +LayerManager::StopFrameTimeRecording()
> +{
> +  mLastFrameTime = TimeStamp();

I would add a comment about how 'TimeStamp()' is the "null" moment that you're using to mark that it's stopped.

Comment 11

[Ali Juma [:ajuma]]

Comment on attachment 577793 [details] [diff] [review]
Add the api

Review of attachment 577793 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/Layers.cpp
@@ +570,5 @@
> +void
> +LayerManager::PostPresent()
> +{
> +  if (!mLastFrameTime.IsNull())
> +    mFrameTimes.AppendElement((TimeStamp::Now() - mLastFrameTime).ToMilliseconds());

Update mLastFrameTime here.

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/90e2471b7a42