Closed
Bug 696461
Opened 13 years ago
Closed 13 years ago
Ux Designs For Primary UI
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox11 fixed, fennec11+)
RESOLVED
FIXED
People
(Reporter: elan, Assigned: madhava)
References
Details
(Whiteboard: [QA+])
Attachments
(4 files)
250.44 KB,
image/jpeg
|
Details | |
28.15 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
2.39 KB,
patch
|
Details | Diff | Splinter Review | |
42.15 KB,
image/png
|
Details |
Meta bug.
Updated•13 years ago
|
Whiteboard: [QA+]
Reporter | ||
Updated•13 years ago
|
Assignee: nobody → madhava
Comment 1•13 years ago
|
||
More polished mocks and assets are on the way, but this should be enough to start with.
Comment 3•13 years ago
|
||
This reskins the primary UI. The values have been moved out of styles for 3 reasons: 1. There are issues with the order each attribute is applied in a relative layout-- and styles are confusing it a bit. 2. The amount of reusability has reduced, and it makes sense to cut down the styles. 3. The relative layout uses id's for placing the view items, and it better not placed in styles. Todos: 1. The "Go" button in awesomebar 2. A back button in awesomebar -- in the place of "tabs" button 3. A lock button in browser-toolbar -- same as "Go" button. --> This will be added as a separate patch once the resources are available for the same.
Attachment #570120 -
Flags: review?(mark.finkle)
Comment 4•13 years ago
|
||
I felt the address bar not having enough affordance to tap on it. And also a visual glitch when a text box with orange border is shown when we tap on it. I tried adding back the original design of having text box background for the button. Pros: Has good affordance and removes the visual glitch while transitioning from address bar to editing it. Cons: Loss of the simple, smooth and elegant design without the "bounding" box for the button. Ian can decide on having this. Will be adding a screenshot of the same in a bit.
Attachment #570296 -
Flags: review?(mark.finkle)
Comment 5•13 years ago
|
||
This is a screenshot after applying Patch 2.
Updated•13 years ago
|
Attachment #570120 -
Flags: review?(mark.finkle) → review+
Comment 6•13 years ago
|
||
Comment on attachment 570296 [details] [diff] [review] Patch 2: Adding affordance to the browser bar Waiting for ibarlow to ui+
Attachment #570296 -
Flags: review?(mark.finkle)
Comment 7•13 years ago
|
||
pushed the first patch: https://hg.mozilla.org/projects/birch/rev/878512b3be8a I think we should close this bug and move any other patches/ideas to new bugs
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 8•13 years ago
|
||
^ build failed https://tbpl.mozilla.org/php/getParsedLog.php?id=7084126&tree=Birch
Comment 9•13 years ago
|
||
Are we having a clean build? I reused a name with a different resource. That's causing the failure. If the obj directory is removed and compiled, the build is fine.
Comment 10•13 years ago
|
||
(In reply to Aaron Train [:aaronmt] from comment #8) > ^ build failed > > https://tbpl.mozilla.org/php/getParsedLog.php?id=7084126&tree=Birch I tried using the Mozilla Clobberer, but it doesn't seem to have worked.
Updated•13 years ago
|
tracking-fennec: --- → 11+
Updated•13 years ago
|
status-firefox11:
--- → fixed
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•