696483 - missing reporterror

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

In nsFormHistory.js we have

       try { this.dbConnection.close(); } catch(e) {}

this should reportError.

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Don't suppress all exceptions.

The only error I have seen in this part of the code was the connection never being created, so this patch replaces the try/catch with an if.

https://tbpl.mozilla.org/?tree=Try&rev=e0b356c9e3aa

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 581607 [details] [diff] [review]
Don't suppress all exceptions.

Review of attachment 581607 [details] [diff] [review]:
-----------------------------------------------------------------

If close() throws, the next call to remove() will fail (since the database file is in use) and we won't be able to proceed with dbOpen() and dbInit() regardless.
The problem is whether the exception will be able to make the Error Console at least, or if it will just be hidden and unreported.
So, just in case, we may still want to also catch and reportError it, also keeping the if condition that looks correct.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: add reportError

https://tbpl.mozilla.org/?tree=Try&rev=87d92d608825

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Fixed
https://tbpl.mozilla.org/?rev=a2928a1ffde5