696491 - The margin between the edit contact star right to an email address and the email address gets smaller after hiding/showing again the singlemessage DOM object

Status: UNCONFIRMED

(Thunderbird :: Message Reader UI, defect)

Description

[Joachim Herb]

Attachment: Top: Position of the star before thread view. Bottom: Position after thread view

The margin between the edit contact star right to an email address and the email address is to small after first time viewing a thread

What did you do?
Click on a message in the folder pane so it is opened in the message pane below/to the right. The star on the right side "edit contact" of the email address is in the correct distance.
Click on a collapsed thread (of messages). Below the preview of the thread should appear.
Click on a single message (again).

What happened?
The star is now placed with a too small margin between it and the email address.

What should have happened?
The margin should not change.
[squib on IRC]: This looks like a core bug. The margin CSS specification is applied only after viewing a thread the first time.
The CSS code is here: http://mxr.mozilla.org/comm-central/source/mail/themes/qute/mail/messageHeader-aero.css#632

Comment 1

[Joachim Herb]

I can reproduce this using Windows and Linux. This bug seems to exist at least since Thunderbird 5 and up to 10.0a1.

Comment 2

[Joachim Herb]

Attachment: Mozmill tests demonstrating the problem

These tree mozmill tests demonstrate the problem:
If an email thread is selected (and back then the non-threaded email) the star position relative to the email address changes so the width of the emailDisplayButton surrounding the email address and the star icon gets smaller.

The old margin between the email address and the star is reset by reopening the 3pane mail window. 

It is enough to toggle hidden attribute of the singlemessage DOM object to trigger this bug, so it is not (really) related to threaded/multimessage view.

Comment 3

[Joachim Herb]

Attachment: Mozmill tests demonstrating that toggling the hidden attribute causes the problem

A new version of the mozmill tests. They demonstrate that the problem is caused by toggling the hidden (javascript) attribute of (any) DOM object containing the star. Changing the DOM attribute collapsed does not cause the problem. (The first assert_equals) in the test. Only the second one fails:

$ make SOLO_TEST=message-header/test-email-star-margin.js mozmill-one
unset PYTHONHOME && cd ./mozilla/_tests/mozmill && MACOSX_DEPLOYMENT_TARGET= \
        /c/Users/joachim/workspace/comm-2/obj-tb/./mozilla/_tests/mozmill/../mozmill-virtualenv/Scripts/python.exe runtest.py \
        --test=/c/Users/joachim/workspace/comm-2/obj-tb/../mail/test/mozmill/message-header/test-email-star-margin.js \
        --binary=../../.././mozilla/dist/bin/thunderbird.exe \
        --symbols-path=/c/Users/joachim/workspace/comm-2/obj-tb/./mozilla/dist/crashreporter-symbols \

Using profile dir: c:\Users\joachim\workspace\comm-2\obj-tb\mozilla\_tests\mozmill\mozmillprofile
TEST-START | c:\Users\joachim\workspace\comm-2\mail\test\mozmill\message-header\test-email-star-margin.js | setupModule
TEST-PASS | c:\Users\joachim\workspace\comm-2\mail\test\mozmill\message-header\test-email-star-margin.js | setupModule
TEST-START | c:\Users\joachim\workspace\comm-2\mail\test\mozmill\message-header\test-email-star-margin.js | test_emailStar_margin_toggle_hidden_attribute
Test Failure: a != b: '196' != '193'.
TEST-UNEXPECTED-FAIL | c:\Users\joachim\workspace\comm-2\mail\test\mozmill\message-header\test-email-star-margin.js | test_emailStar_margin_toggle_hidden_attribute
TEST-START | c:\Users\joachim\workspace\comm-2\mail\test\mozmill\message-header\test-email-star-margin.js | teardownModule
TEST-PASS | c:\Users\joachim\workspace\comm-2\mail\test\mozmill\message-header\test-email-star-margin.js | teardownModule
INFO Passed: 2
INFO Failed: 1
INFO Skipped: 0
SUMMARY-UNEXPECTED-FAIL | c:\Users\joachim\workspace\comm-2\mail\test\mozmill\message-header\test-email-star-margin.js | test_emailStar_margin_toggle_hidden_attribute
  EXCEPTION: a != b: '196' != '193'.
    at: test-folder-display-helpers.js line 2842
       assert_true(false,"a != b: '196' != '193'.") test-folder-display-helpers.js 2842
       assert_equals(196,193) test-folder-display-helpers.js 2829
       test_emailStar_margin_toggle_hidden_attribute() test-email-star-margin.js 105
            frame.js 554
            frame.js 623
            frame.js 666
            frame.js 503
            frame.js 678
            server.js 182
            server.js 186
make: *** [mozmill-one] Error 1

Comment 4

[Joachim Herb]

I run the mozmill test on the try server:
Linux:
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1319580729.1319581380.2404.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1319581693.1319582356.4024.gz&fulltext=1
*** http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1319586328.1319587324.13185.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1319590623.1319591392.20386.gz&fulltext=1

Mac OS X:
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1319657082.1319657835.1519.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1319639169.1319639925.27185.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1319639946.1319640696.28688.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1319651844.1319652595.23737.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1319656737.1319657492.811.gz&fulltext=1

Windows:
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1319619270.1319620205.10433.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1319619313.1319620505.10822.gz&fulltext=1

Only the one mozmill test run marked with (***) above seems to PASS. All other fail.

Any idea where to start looking for an explanation of this problem?

Comment 5

[Mark Banner (:standard8)]

Its a bit hard to tell, but most of the failures seem to be random, this one is more or less consistent (which is the one you're looking at):

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/message-header/test-email-star-margin.js | test_emailStar_margin_toggle_hidden_attribute
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

For the rest of them, you can generally look at:

http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry

click the build that's failing and you'll get a summary, plus possible bugs for the random orange if there are any.

Comment 6

[Ludovic Hirlimann [:Usul]]

Henrik ideas ?

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I'm not sure what I should answer. Mozmill tests for Thunderbird are quite different given the own shared modules. I would need a better explanation of the problem to give an answer if this is Mozmill core related.

Comment 8

[Joachim Herb]

The mozmill test just demonstrates this problem. It appears in Thunderbird all the time (at least using Windows) if you switch between multi message view and single view.