696494 - Get rid of all gBrowser references in Mozmill

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Andrew Halberstadt [:ahal]]

In desktop Firefox you can use the global gBrowser object to get a reference to the tabbedbrowser. In Fennec, this global object doesn't exist. Instead you need to call window.getBrowser();

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - Replace gBrowser with getBrowser()

This patch replaces all instances of gBrowser with getBrowser().
It passes all the mutt tests (js and python) in desktop Firefox. Note that most (if not all) mozmill tests will still fail in fennec due to chrome code touching content.

Comment 2

[Jeff Hammel]

Comment on attachment 568785 [details] [diff] [review]
Patch 1.0 - Replace gBrowser with getBrowser()

i'm surprised that's all there is but if it passes tests, looks good :)

Comment 3

[Jeff Hammel]

confirmed that this passes with mutt for me (linux 32, nightly)

Comment 4

[Andrew Halberstadt [:ahal]]

Yeah, I'm surprised it was that simple as well, though it makes sense since gBrowser is basically just a convenience object.

master: https://github.com/mozautomation/mozmill/commit/73a99688375719e300281d40f7693573e3dbd086