696572 - Port |Bug 681588 - Cleanup wrap malloc and its use on Android| to comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Serge Gautherie (:sgautherie)]

Found while working on bug 694371.

Let's resync' c-c (step by step).

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Replace WRAP_MALLOC_* with WRAP_LDFLAGS [Checked in: Comment 5]

Please double check whether the last configure.in block (= export + sed) is wanted or not.
Ftr,
0) in bug 605376, I had not ported the old block, as I thought it was useless as is,
1) in the current bug, I assume c-c should have the new block wrt 'mozilla',
2) then I also wonder whether some kind of support should be added to LDAP C-SDK too (in a separate bug).

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 568895 [details] [diff] [review]
(Av1) Replace WRAP_MALLOC_* with WRAP_LDFLAGS
[Checked in: Comment 5]

Sorry, but this looks like Android-only/largely Android specific. As none of our c-c apps currently work with android, I'm not willing to spend time reviewing Android specific patches. I'd much rather have the time spent on bug 648979 which would stop the need for us for porting these bugs. You are welcome to ask other build config peers.

Comment 3

[Robert Kaiser]

Comment on attachment 568895 [details] [diff] [review]
(Av1) Replace WRAP_MALLOC_* with WRAP_LDFLAGS
[Checked in: Comment 5]

Review of attachment 568895 [details] [diff] [review]:
-----------------------------------------------------------------

I don't really care about Android, as no c-c apps build on it anyhow, but I'd rather r+ it than let anyone else lose time over it.

Other than that, I agree with Mark's comment, though.

Comment 4

[Robert Kaiser]

Oh, and FTR, this merges bug 680373 and bug 681588 both into one patch against c-c.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 568895 [details] [diff] [review]
(Av1) Replace WRAP_MALLOC_* with WRAP_LDFLAGS
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/410f1fa9ebc6


(In reply to Robert Kaiser (:[e-mail]) from comment #4)
> Oh, and FTR, this merges bug 680373 and bug 681588 both into one patch
> against c-c.

I don't think so: bug 680373 is ported in bug 696455.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #5)
> 
> (In reply to Robert Kaiser (:[e-mail]) from comment #4)
> > Oh, and FTR, this merges bug 680373 and bug 681588 both into one patch
> > against c-c.
> 
> I don't think so: bug 680373 is ported in bug 696455.

Ah, I see what you mean: I agree, but I preferred to do them separately :-|