696833 - Ux Designs for Awesome Screen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Erin Lancaster [:elan]]

Meta bug.

Comment 1

[Ian Barlow (:ibarlow)]

Attachment: mockup of awesomescreen interactions

More polished mocks and assets are on the way, but this should be enough to start with.

Comment 2

[Ian Barlow (:ibarlow)]

Attachment: More detailed mocks

Comment 3

[Ian Barlow (:ibarlow)]

Attachment: Specs (based on 320px wide phone)

Comment 4

[Lucas Rocha (:lucasr)]

Taking this bug now that we have UI spec for it.

Comment 5

[Lucas Rocha (:lucasr)]

Attachment: (1/2) Change style of awesome bar entry as per design

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: (2/2) Implement dynamically coloured tabs in AwesomeBar

Comment 7

[Lucas Rocha (:lucasr)]

Mark (or anyone with different Android devices), could you install this apk on your device and send a screenshot? Just want to test the patch at least in one different device to make sure it works as expected.

APK: http://www.box.net/shared/z8ihpkj5gg2tf7noaaa1

Comment 8

[Lucas Rocha (:lucasr)]

Attachment: Screenshot on a Galaxy S

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 573210 [details] [diff] [review]
(2/2) Implement dynamically coloured tabs in AwesomeBar

>+    static {
>+        // We wan to use the same color on the list items (in pressed state)

We want

Comment 10

[Lucas Rocha (:lucasr)]

Follow-up bugs:

 - Add 'Go' button to AwesomeBar text entry 
   https://bugzilla.mozilla.org/show_bug.cgi?id=701329

 - Show star on urls that are bookmarks in AwesomeBar screen
   https://bugzilla.mozilla.org/show_bug.cgi?id=701330

Comment 11

[Lucas Rocha (:lucasr)]

Pushed:
http://hg.mozilla.org/projects/birch/rev/74eee623c0a0
http://hg.mozilla.org/projects/birch/rev/c5f8e6042fb8

Comment 12

[Wesley Johnston (:wesj)]

These patches were backed while investigating Talos failures.  Now that tests are green again, we will need to reland.

Comment 13

[Sriram Ramasubramanian [:sriram]]

I was looking for coloring the browser toolbar with the system color. I found this: android.R.attr.textColorHighlight (ARGB value). This might work for getting the color I guess.

Comment 14

[Sriram Ramasubramanian [:sriram]]

ContextThemeWrapper ctw = new ContextThemeWrapper(mContext, android.R.style.TextAppearance);
TypedArray ta = ctw.getTheme().obtainStyledAttributes(new int[] { android.R.attr.textColorHighlight });
int color = ta.getColor(ta.getIndex(0), 0);

The above code gives the color of orange #FFFF9200 on stock gingerbread (Nexus S),
and #FF428EBA on Samsung Galaxy S2 (their blue) color.

I feel this would be a clear code and the perfect color to use.

Comment 15

[Cristian Nicolae (:xti)]

Attachment: screenshot on Motorola Droid 2

The selected tab text color is black instead of white on the latest Nightly build.

--
Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20111111
Firefox/10.0a1 Fennec/10.0a1
Devices: Motorola Droid 2
OS: Android 2.3.3

Comment 16

[Brad Lassey [:blassey] (use needinfo?)]

backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547

Comment 17

[Aaron Train [:aaronmt]]

20111114041052
http://hg.mozilla.org/projects/birch/rev/859ecdfe0168
Samsung Galaxy SII (Android 2.3.4)