696914 - IndexedDB: IDBObjectStore.delete and IDBCursor.delete should return undefined

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I.e. the .result of the returned request should be set to true if a record was deleted, and false otherwise.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Based on discussions at TPAC, I think we'll end up changing the spec here to always return undefined.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Woo! Otherwise we were going to have to hack something into mozStorage to expose the data we need from SQLite.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to ben turner [:bent] from comment #2)
> Woo! Otherwise we were going to have to hack something into mozStorage to
> expose the data we need from SQLite.

http://www.sqlite.org/c3ref/changes.html

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Has r=sicking.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/mozilla-central/rev/966c69671224

Comment 6

[Jan Varga [:janv]]

(In reply to ben turner [:bent] from comment #3)
> (In reply to ben turner [:bent] from comment #2)
> > Woo! Otherwise we were going to have to hack something into mozStorage to
> > expose the data we need from SQLite.
> 
> http://www.sqlite.org/c3ref/changes.html

I had to add this for Files in IndexedDB

Comment 7

[Jean-Yves Perrier [:teoli]]

I'm trying to document this. I have a question.

As both in the published spec (TR) and the editor's draft give an IDBRequest as the result for the two method, could you confirm that it is the IDBResult.result that really returns undefined?

Thank you in advance

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yes, that's correct. For all database operations the "result" is retrieved through IDBRequest.result once the success event is fired.

Comment 9

[Jean-Yves Perrier [:teoli]]

I updated:
https://developer.mozilla.org/en/IndexedDB/IDBObjectStore#delete%28%29
https://developer.mozilla.org/en/IndexedDB/IDBCursor#delete%28%29

and of course
https://developer.mozilla.org/en/Firefox_10_for_developers#section_8