697000 - Token type shouldn't be set after the other fields, to allow the setting of those fields to be asserted type-safe

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Currently we set fields like token.u.reflags before we set token.type.  This means that we can't assert that, when reflags is set, its type is TOK_REGEXP.  We should initialize in an order that makes such assertions possible, for all the various token-mutation methods.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Do kind-checking in Token's setters.

In bug 898912, I thought about removing |tt| and just working directly with
|tp->type|, but I didn't end up doing it.

And then I saw this bug and realized that if I made that change it would be
really easy to fix.  So here you go.  The performance effect is negligible.

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 784788 [details] [diff] [review]
Do kind-checking in Token's setters.

Review of attachment 784788 [details] [diff] [review]:
-----------------------------------------------------------------

nice

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/786c07374154

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/786c07374154