697048 - Copy surface data URL's to clipboard

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: Copy data URL's to clipboard as well

Having these only dump to stdout can be hard to use, we should copy them to the clipboard as well.

It might be nice to have a way to specify where you want the output to go, not sure how to make this easy to use from a debugger though.

Maybe just multiple functions?

Comment 1

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 569321 [details] [diff] [review]
Copy data URL's to clipboard as well

Better patch coming.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Add multiple output formats for DumpAsDataURL

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Add multiple output formats for DumpAsDataURL v2

Fixed a strlen bug, add gfxContext wrappers and made it fail less often by using GetAsImageSurface.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 569578 [details] [diff] [review]
Add multiple output formats for DumpAsDataURL v2

Review of attachment 569578 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxASurface.cpp
@@ +853,5 @@
> +
> +  const char* prefix = "data:image/png;base64,";
> +  PRUint32 len = strlen(encodedImg) + strlen(prefix) + 1;
> +  char *fullString = new char[len];
> +  snprintf(fullString, len, "%s%s", prefix, encodedImg);

Why not use nsCString instead?

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Add multiple output formats for DumpAsDataURL v3

Good point, C char arrays are horrible.

Comment 6

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d21cf5b59d0

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8d21cf5b59d0