697144 - Unable to interact with aboutCertError

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Aaron Train [:aaronmt]]

STR: 

1. https://jal.jp
2. Tap any of the <xul:buttons>

<xul:buttons> -> android.widget.Button
 
--
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111025 Firefox/10.0a1 Fennec/10.0a1

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #0)

> <xul:buttons> -> android.widget.Button

Nope. We just need to port the code over to allow the about:certerror page to work

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch adds the required code to handle "clicking" in about error pages. Sane code used in XUL Fennec (minus the e10s) and desktop Firefox.

The patch also removes the nagging "error" about not finding the Private Browsing service. Seeing an "error" in logcat only adds to testing confusion.

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 569945 [details] [diff] [review]
patch

This feels like a hack, but I see it's a hack we inherited from desktop Firefox long ago.  I don't have any better suggestions, so whatever.   :)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/projects/birch/rev/9fe52ea2201f

Comment 5

[Aaron Train [:aaronmt]]

20111028040427
http://hg.mozilla.org/projects/birch/rev/cdb0a41ea68c