Closed Bug 697168 Opened 13 years ago Closed 13 years ago

ReadPixels, TexImage2D, and TexSubImage2D incorrectly accept untyped array buffers

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla10

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(1 file, 1 obsolete file)

Remove non-spec ArrayBuffer overloads for readPixels, texImage2D, and texSubImage2D
12.56 KB, patch
bjacob
: review+
Details | Diff | Splinter Review 
The WebGL spec requires that readPixels only takes typed arrays, not untyped array buffers.
Summary: ReadPixels incorrectly accepts untyped array buffers → ReadPixels, TexImage2D, and TexSubImage2D incorrectly accept untyped array buffers
Blocks: 697560
ReadPixels should also no longer need a dummy IDL stub, since there's only one valid set of arguments. I have had trouble actually removing the stub, but the functionality is the same just leaving it in.
Matching try: https://tbpl.mozilla.org/?tree=Try&rev=997e3381d771
Status: NEW → ASSIGNED
Blocks: 697753
Unbitrotted.
Attachment #569783 - Attachment is obsolete: true
Attachment #569783 - Flags: review?(bjacob)
Attachment #570029 - Flags: review?(bjacob)
Attachment #570029 - Flags: review?(bjacob) → review+
Blocks: webgl-conformance
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cd25d4a839b
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
Removed [inbound] from whiteboard as per https://wiki.mozilla.org/Tree_Rules/Inbound
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/2cd25d4a839b
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: