Closed
Bug 697336
Opened 13 years ago
Closed 13 years ago
Clean up nsDataObj::SetText on Windows
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: m_kato, Assigned: m_kato)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.10 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
Although I look HG/CVS log by http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/widget/src/windows/nsDataObj.cpp&rev=1.90, I cannot make sense why nsDataObj::SetText() doesn't return E_FAIL simply. Also, FALSE (=0) means S_OK (=0), so this is broken.
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → m_kato
Attachment #570587 -
Flags: review?(jmathies)
|
||
Updated•13 years ago
|
Attachment #570587 -
Flags: review?(jmathies) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/470ed3885e3c
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/470ed3885e3c I love it when people make this file less awful.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•