697726 - Stop

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Aaron Train [:aaronmt]]

Re-add the the ability to stop page load.

Comment 1

[Doug Turner (:dougt)]

not in the design spec.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

don't listen to dougt

Comment 3

[Madhava Enros [:madhava]]

Sorry, who?

When a page is loading, let's have a button at the end of the titlebar (i.e. where we put it in previous versions). The difference is that we won't replace it with refresh in the new one. When you need stop, it's pretty useful to have to have it available immediately.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Madhava Enros [:madhava] from comment #3)
> The difference is that we won't
> replace it with refresh in the new one. 

why not?

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Brad Lassey [:blassey] from comment #4)
> (In reply to Madhava Enros [:madhava] from comment #3)
> > The difference is that we won't
> > replace it with refresh in the new one. 
> 
> why not?

or more specifically, what do you want to do here? have it go away when the page finishes loading? or just have a disabled stop button when the page finishes loading? If its the latter, I think it would be better for it to turn into a refresh button. For the former I wonder how that transition will look.

Comment 6

[Ian Barlow (:ibarlow)]

Attachment: URL bar states

Hi everyone, here's a mock of all the various URL bar states that should clarify some of these interaction questions. 

With regard to the Stop button, it only appears when the page is loading, and then goes away once loading has finished.

Comment 7

[Ian Barlow (:ibarlow)]

Attachment: Graphic assets for header icons

Includes Stop, Lock, and Go icons, prepared for Gingerbread and ICS

Comment 8

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch adds the stop functionality.

I am not sure if I should send the event directly from BrowserToolbar. I tried to be consistent in call GeckoApp from BrowserToolbar, which inturn calls Tab's stop().

We need high resolution assets for stop button.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/projects/birch/rev/14e6f9bd949d

Comment 10

[Aaron Train [:aaronmt]]

Samsung Nexus S (Android 2.3.6)
20111118040220
http://hg.mozilla.org/projects/birch/rev/9999a423d8ab