Closed
Bug 697917
Opened 13 years ago
Closed 13 years ago
Avoid atomizing the token for nsDOMTokenList containment tests
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
6.10 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
We can easily do them on the string itself, and in the common case (few classes) the atomization is more expensive than just comparing strings.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #570156 -
Flags: review?(Olli.Pettay)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 570156 [details] [diff] [review] Avoid atomizing the token for nsDOMTokenList containment tests. Looks like nsTArray documentation is a bit wrong http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsTArray.h#410 Comparator::Equals parameters both have elem_type, but the latter one could be actually something else like in this patch.
Attachment #570156 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Good catch. I'll fix the docs.
|
|
Assignee | |
Comment 4•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/0371519c061e
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla10
|
||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0371519c061e
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•