698088 - Initializing WebGL fake-black textures doesn't rebind previous texture bindings before drawing

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

When there are textures in a context which (for an as-per-spec reason) must be rendered as black, we initialize face-black textures as a prefix to the next draw. When creating these textures, we naturally must change the current texture bindings, which is fine, as long as we reset them to their previous state when we're done. However, instead, we reset the 2d and cubemap textures to 0, instead of the previous values.

This causes the conformance tests for copyTexImage2D and copyTexSubImage2D to fail.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Fix to rebind previous GL state after initializing fake-black textures

Short and sweet, but unbelievably annoying to track down. APITrace is awesome, though.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Fix to rebind previous GL state after initializing fake-black textures

Removed copyTexImage2D and copySubTexImage2D from list of failing tests for all platforms.

Comment 3

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c4f4dc3d3b20

Comment 4

[Kelsey Gilbert [:jgilbert]]

Removed [inbound] from whiteboard as per https://wiki.mozilla.org/Tree_Rules/Inbound

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/c4f4dc3d3b20