698162 - Session Restore (and Undo-Close-Tab) restores bug pages with "Reset Assignee to default" and "Reset QA Contact to default" checked

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 0. Be logged into bugzilla (and have editbugs)
 1. Have a bugzilla.mozilla.org bug page open. (e.g. this one)
 2. Quit Firefox, saving your session if prompted.
 3. Start firefox (restoring your session)
   (Note: I have "restore session" set to happen automatically in the Firefox preferences; not sure if this is required to trigger the bug.)

ACTUAL RESULTS:
When the bug page comes back up, it's got the Assignee & QA Contact fields both as editable textfields (as if you'd hit the "edit" link next to them), and the "Reset Assignee to default" and "Reset QA Contact to default" boxes are both checked.

This bit me earlier today -- I opened a bug page, then restarted firefox, and then added someone to the CC list for the bug -- but I inadvertantly cleared the bug assignee in the process.

This bug happens 100% for me on today's nightly, but never happens with yesterday's nightly. (performing the full STR with one nightly or the other)
Regression range is:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4bb7c983d589&tochange=322354df233d
which includes some session restore patches.  CC'ing zpao, who wrote or reviewed all of those patches, in the hopes that he can tell which might have broken this.

Mozilla/5.0 (X11; Linux x86_64; rv:10.0a1) Gecko/20111028 Firefox/10.0a1

P.S. edmorley says he hit this in today's nightly, too, in Win7 wow64

Comment 1

[Daniel Holbert [:dholbert]]

This happens for bugs in background tabs, as well.  So if you have 10 bugs open, then they'll all have those checkboxes default-checked (so the next action you perform on any bug will clear the assignee, if you're not careful).

The assignee textfield becomes the focused field in each of my bug tabs, too.

Comment 2

[Daniel Holbert [:dholbert]]

SIMPLER STR:
 1. Load this bug page (or any bug page)
 2. Ctrl+W        (close tab)
 3. Ctrl+Shift+T  (undo close tab)

Boom. Page is restored with reset assignee & QA contact checked.

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I backed out bug 640136 with https://hg.mozilla.org/mozilla-central/rev/dfbe9a0fbf97

I'm going to resolve this for now on the assumption its a bug on our side. It doesn't look like we're doing anything inherently wrong - we're not restoring form data for any assignee-related fields. It may turn out that bugzilla is doing something bad (but if so, who knows what else we'll break).