Closed Bug 698261 Opened 13 years ago Closed 13 years ago

Remove the aElementType argument of NS_NewElement

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Patch v1
13.45 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
      No description provided.
Flags: in-testsuite-
Attached patch Patch v1 — — Splinter Review 

        Attachment #570541 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 570541 [details] [diff] [review]
Patch v1

Why do you need the on-stack nodeInfo?  You can just do:

  PRInt32 ns = aNodeInfo.get()->NamespaceID();

right?

r=me with that.

        Attachment #570541 -
        Flags: review?(bzbarsky) → review+

    
    

    
  
I guess I can... It's just that playing around with already_AddRefed pointers scares me a little.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1a9c14f23f32
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → mozilla11
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: