698534 - Build fails when smil is disabled

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v2

Looks like other things were broken.

Comment 2

[Robert Longson [:longsonr]]

Wouldn't we be better just removing the MOZ_SMIL defines and having SMIL in the build always.

Comment 3

[Mounir Lamouri (:mounir)]

(In reply to Robert Longson from comment #2)
> Wouldn't we be better just removing the MOZ_SMIL defines and having SMIL in
> the build always.

Most of my dev builds have --disable-smil and I didn't get that many issues with SMIL. Actually, it's been a long time since I got any build issues because of my disabled options.

However, if the reasons why this option exist doesn't apply anymore, I would be fine with removing it. Though, can we fix that bug first? :)

Comment 4

[Daniel Holbert [:dholbert]]

Comment on attachment 570802 [details] [diff] [review]
Patch v2

Looks good.  Sorry for not having caught this in review on bug 693145.

I'll file a separate bug on removing MOZ_SMIL #ifdefs.

Comment 5

[Daniel Holbert [:dholbert]]

(Filed bug 698630 on removing the --disable-smil option)

Comment 6

[Daniel Holbert [:dholbert]]

volkmar landed this as:
http://hg.mozilla.org/integration/mozilla-inbound/rev/b2c58afeead0

Removing [inbound] per https://wiki.mozilla.org/Tree_Rules/Inbound

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b2c58afeead0