698703 - Source Editor should display text with the user's preferred monospace font size

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Cedric Vivier [:cedricv]]

SourceEditor currently uses a fixed size of 10pt on all platforms.
It should probably rather use the user's preferred monospace font size (Preferences -> Content -> Fonts).

It also helps to integrate SourceEditor with other browser UI.

Comment 1

[Cedric Vivier [:cedricv]]

Attachment: Use preferred monospace font size

Comment 2

[Mihai Sucan [:msucan]]

Comment on attachment 570954 [details] [diff] [review]
Use preferred monospace font size

Review of attachment 570954 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for your patch. r+ with the comment below addressed.

(please rebase on top of the latest fx-team. thanks!)

::: browser/devtools/sourceeditor/orion/mozilla.css
@@ +1,5 @@
>  /* Any copyright is dedicated to the Public Domain.
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +.viewContainer,
> +.rulerTooltip {

.rulerTooltip is unused.

The ruler copies the styling of .viewContainer, so just setting font-size: inherit for .viewContainer is sufficient.

Comment 3

[Cedric Vivier [:cedricv]]

Attachment: v2, removed .rulerTooltip that got removed in recent Orion update

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 570961 [details] [diff] [review]
v2, removed .rulerTooltip that got removed in recent Orion update

>+	font-size: inherit; /* inherit browser's default monospace font size */

Replace the tab with two spaces.

Comment 5

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/f5bc569a7c01

(with dão's suggestion from c#4)

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/f5bc569a7c01