698837 - use signed updater.exe for elm and oak branches

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

bug 696777 lets us inject an already signed updater.exe into a new build. We need to enable this for the elm and oak twigs, which are being used for bug 481815. Basically, we need to set MOCO_SIGNED_UPDATER_EXE to an URL that points to the signed updater.exe.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: merge environments instead of overwriting; set MOZ_SIGNED_UPDATER_EXE for elm and oak

Lukas, what do you think of merging project branch environments instead of overwriting them?

Comment 2

[Brian R. Bondy [:bbondy]]

Any ETA on this landing?

Comment 3

[[e-mail] (:bhearsum)]

This already landed. It won't take effect until elm and oak get https://bugzilla.mozilla.org/show_bug.cgi?id=696777.

Comment 4

[Brian R. Bondy [:bbondy]]

nice! So it seems I can use bug 696777 on elm as of today if I push the unreviewed patch right? I'll just re-push any changes that it gets after review.

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Brian R. Bondy [:bbondy] from comment #4)
> nice! So it seems I can use bug 696777 on elm as of today if I push the
> unreviewed patch right? I'll just re-push any changes that it gets after
> review.

You're welcome to try. I take no responsibility for any damage though ;)

Comment 6

[[e-mail] (:bhearsum)]

This isn't working for some reason.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Presumably because this patch uses MOZ_SIGNED_UPDATER_EXE and the build system patch uses MOCO_SIGNED_UPDATER_EXE?

Comment 8

[[e-mail] (:bhearsum)]

Ah, it looks like the only problem here is that there hasn't been an update to the production buildbots since I landed this patch. I'll make sure that happens today.(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #7)
> Presumably because this patch uses MOZ_SIGNED_UPDATER_EXE and the build
> system patch uses MOCO_SIGNED_UPDATER_EXE?

*facepalm*. Yes, that. But I also noticed that this never made its way to the production buildbots. I landed a fix in http://hg.mozilla.org/build/buildbot-configs/rev/d00364ebead8, and there will be a reconfig at some point today to pick it up.

Comment 9

[Armen [:armenzg]]

This went live at 8:45 AM PDT.

Comment 10

[Brian R. Bondy [:bbondy]]

Ready for me to retry?

Comment 11

[[e-mail] (:bhearsum)]

(In reply to Brian R. Bondy [:bbondy] from comment #10)
> Ready for me to retry?

Yup!

Comment 12

[[e-mail] (:bhearsum)]

The path to this got changed a bit with a patch in bug 696777.