Closed
Bug 699008
Opened 13 years ago
Closed 13 years ago
In the release configs, binaryName should be Thunderbird not thunderbird
Categories
(Mozilla Messaging Graveyard :: Release Engineering, defect)
Mozilla Messaging Graveyard
Release Engineering
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(2 files)
2.41 KB,
patch
|
jhopkins
:
review+
|
Details | Diff | Splinter Review |
32.21 KB,
patch
|
jhopkins
:
review+
|
Details | Diff | Splinter Review |
In looking at the *_update_verify_31 failures on Mac and Linux I noticed that they are failing because they can't download some files e.g. Executing: ['wget', '--no-check-certificate', '-nv', 'stage-old.mozilla.org/pub/mozilla.org//thunderbird/releases/3.1.15/mac/af/thunderbird 3.1.15.dmg'] Failed, sleeping 1 seconds before retrying The name of the file is "Thunderbird 3.1.15.dmg" not the lower case version. Looking around a bit, it is easy to spot the Firefox is using "Firefox" for the binary name in the release config, not "firefox". Looking at the code this follows suit: - The update verify bump script lowercases binary name for Linux but not Windows or Mac: http://hg.mozilla.org/build/tools/annotate/834acc8e4a21/release/update-verify-bump.pl#l216 - The only other uses are for generating the mar name, which gets lower-cased as well: http://hg.mozilla.org/build/buildbotcustom/annotate/032646bdc420/process/factory.py#l4735
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #571288 -
Flags: review?(jhopkins)
Assignee | ||
Comment 2•13 years ago
|
||
It is unclear whether or not the update-verify-bump script would actually correct the old file names or not. Therefore I've gone for a manual correction, which ensure we get everything right, and we should be able to run the verify builds again to prove we've got the new configs right. I should be able to commit these as they aren't in cvs ;-)
Attachment #571289 -
Flags: review?(jhopkins)
Updated•13 years ago
|
Attachment #571288 -
Flags: review?(jhopkins) → review+
Updated•13 years ago
|
Attachment #571289 -
Flags: review?(jhopkins) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Checked in: http://hg.mozilla.org/build/buildbot-configs/rev/ec39a14d9af2 http://hg.mozilla.org/build/tools/rev/6cd65d34fb95 I've triggered the verify builders and initial indications are they are working fine.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•