699192 - Uploading dowloaded minified jquery file causes unicode error

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P1)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Attachment: error from upload

If I try to add the  current release of jQuery to my project by url:

http://code.jquery.com/jquery-1.6.4.min.js

...I get an error ( see attached screenshot ).

Comment 1

[Daniel Buchner [:dbuc]]

Piotr, let's get this and the rest of the unicode issues taken care of as soon as possible.

Comment 2

[Piotr Zalewa [:zalun]]

https://github.com/mozilla/FlightDeck/pull/73

Comment 3

[Will Bamberg [:wbamberg]]

I still see this, or it's come back. Trying to attach the minified jQuery, for example: http://code.jquery.com/jquery-1.7.1.min.js, I see the same error:

***
Error 403

FORBIDDEN
'Attachment failed to save properly
Unknown Unicode in file'
***

Comment 4

[Piotr Zalewa [:zalun]]

It is working fine

Comment 5

[Will Bamberg [:wbamberg]]

It reliably does not work for me.

* jQuery.min downloaded from http://code.jquery.com/jquery-1.7.2.min.js
* Mac OS X 10.6.8
* Firefox 13

I've tried with a clean profile, same problem.

This has been reported elsewhere since this bug was closed, for example:
http://stackoverflow.com/questions/9769108/unable-to-upload-jquery-1-7-1-min-for-firefox-addon-using-addon-builder
https://forums.mozilla.org/addons/viewtopic.php?p=11257&sid=2e7016d0aed3457c9243ba33fd6fc950

Comment 6

[Piotr Zalewa [:zalun]]

There is indeed an error if file was downloaded an then uploaded.
Adding the file by providing its URL is working fine.
The description is about the latter which was fixed, that's why I marked it as resolved.

STR:

1. download http://code.jquery.com/jquery-1.7.2.min.js
2. open add attachent modal
3. select the file from disk and submit the form

Comment 7

[Piotr Zalewa [:zalun]]

In review https://github.com/mozilla/FlightDeck/pull/155

Comment 8

[Piotr Zalewa [:zalun]]

on master