699239 - Show only unfinished items in template section of the l10n dashboard

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P2)

Description

[Thomas Schwecherl]

Template section of the l10n dashboard at SUMO is useless in its current shape. The entries are only sorted by alphabetical order(?). Other lists of this page are sorted by visitors for logical reasons. If you want to know if or which template must be updated/translated, you _must_ click on the "all templates..." link.

Suggestion:
The template section should only show unfinished (untranslated or out-of-date) templates. So you can see at a glance if you have to do something. If all templates are translated and up-to-date, show a little string like "All template translations are done" ore something similar to show that it's no error that the template list is empty.

Comment 1

[Kadir Topal [:atopal]]

This is indeed a problem, short term stop gap solution: 

Order by status of localization first, and name second.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Sprint based milestone :-)

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pretty sure this involves changing the where clause in the sql in TemplateTranslationReadout and then adding tests. The latter part probably taking the most time.

Grabbing this one.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pull request: https://github.com/mozilla/kitsune/pull/570

I didn't change the where or order_by clauses in the sql. I ended up fixing the Readout class so that it has a separate sort_and_truncate step.

So what happens now is that the Template section shows all the templates, but the ones that need translation show up at the top of the list. That fixes the problem statement, but doesn't force us to change the code to handle a "everything is translated" special case.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/kitsune/commit/564622291e3d951b1567d23524764d32efc3b877

Pushed to production just now.