699459 - Add a pref to disable Battery API

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Something like "dom.battery.enabled". true by default but can be turned false. In that case, I don't know if navigator.mozBattery should return null or if we should return the default values. I'm worried returning null might break some websites.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Or not be exposed at all?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

The property shouldn't be defined at all.  That's what we do for other preffable DOM features.

See nsIDOMStorageIndexedDB.

Comment 3

[Mounir Lamouri (:mounir)]

That would be better indeed but that would make changing the pref during run time useless, right? Seems a fair trade though.

Comment 4

[Boris Zbarsky [:bzbarsky]]

> That would be better indeed but that would make changing the pref during run time
> useless, 

Depends on how we implement.  If we look at the pref during prototype setup, then flipping the pref and reloading the page would work.  If we only look at it during the classinfo initialization stuff then flipping it would need a browser restart, yes.

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 6

[Mounir Lamouri (:mounir)]

We should probably push this before the Aurora uplift (the 8th). Worst case, we could directly push it to Aurora but better to prevent this.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ae94f0235649