Closed Bug 699475 Opened 13 years ago Closed 13 years ago

Integrate RuleView into Highlighter Sidebar

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 10

People

(Reporter: rcampbell, Assigned: rcampbell)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 4 obsolete files)

RuleView in Sidebar 2
13.59 KB, patch
dcamp
: review+
Details | Diff | Splinter Review 
Add the cssRuleView to the Highlighter's Sidebar.
Attached patch WIP 1 (obsolete) — — Splinter Review 
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED

    
    

    
  

      
      
      
      

        Attached patch
          
          
        WIP 2 (obsolete)
        — 
          — Splinter Review
      

    


  
behavior seems to be fixed, added entries to inspector.properties for strings. Just haven't checked the tests yet.

        Attachment #571709 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        RuleView in Sidebar (obsolete)
        — 
          — Splinter Review
      

    


  
Updated patch, added unittests, cleanup code and improved functionality.

        Attachment #571728 -
        Attachment is obsolete: true

        Attachment #571761 -
        Flags: review?(dcamp)

    
  

        Attachment #571761 -
        Flags: review?(dcamp) → review+

    
    

    
  

      
      
      
      

        Attached image
          
        Mac Screenshot (obsolete)
        — 
      

    


  

    
    

    
  
Comment on attachment 571776 [details]
Mac Screenshot

wrong place for the screenshot.

        Attachment #571776 -
        Attachment is obsolete: true

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/87ce80260f22
Whiteboard: [fixed-in-fx-team] → [backed-out]

    
    

    
  


  
Updated version. More tests. Checks for and disables extra set buttons in sidebar. Tests tab switching with sidebar tools active.

        Attachment #571761 -
        Attachment is obsolete: true

        Attachment #571994 -
        Flags: review?(dcamp)

    
    

    
  
current try build running here:

https://tbpl.mozilla.org/?tree=Try&rev=4bfaea2d57cb

    
  

        Attachment #571994 -
        Flags: review?(dcamp) → review+

    
    

    
  
relanded:

https://hg.mozilla.org/integration/fx-team/rev/482f32dcd1eb
Whiteboard: [backed-out] → [fixed-in-fx-team]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/482f32dcd1eb
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: