699541 - Pasted HTML shows twice in Orion

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Description

[Mihai Sucan [:msucan]]

(cross-post from https://bugs.eclipse.org/bugs/show_bug.cgi?id=362835 )

STR:

1. Open Scratchpad.
2. Select some HTML from any tab and Paste into Scratchpad.
3. Notice how the pasted text shows twice.

If you use Edit > Paste you also get:

Error: An error occurred executing the cmd_paste command: [Exception...
"Component returned failure code: 0x80004005 (NS_ERROR_FAILURE)
[nsIController.doCommand]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)" 
location: "JS frame :: chrome://global/content/globalOverlay.js :: goDoCommand
:: line 96"  data: no]
Source File: chrome://global/content/globalOverlay.js
Line: 100

(in the Error Console)

Comment 1

[Mihai Sucan [:msucan]]

Attachment: proposed fix

This is the proposed fix and a test.

I provided detailed description of the fix upstream. Please see:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=362835#c0

Please let me know if anything needs to change. Thank you!

Comment 2

[Mihai Sucan [:msucan]]

Forgot to mention I also pushed the patch to the try server:

https://tbpl.mozilla.org/?tree=Try&rev=11995cd8f63f

Comment 3

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/8a0ec6782f96

Comment 4

[Mihai Sucan [:msucan]]

This fix has also landed upstream.

Comment 5

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/8a0ec6782f96