699661 - Make obj->getElement actually call into the ops getElement hooks

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Should help with arrays of various sorts.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Call the class getElement hook from JSObject::getElement as needed.

Comment 2

[David Mandelin [:dmandelin]]

(In reply to Boris Zbarsky (:bz) from comment #0)
> Should help with arrays of various sorts.

Help what? That's a pretty terse description. ;-) Is this just a bug in the way we use ops?

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 571849 [details] [diff] [review]
Call the class getElement hook from JSObject::getElement as needed.

Review of attachment 571849 [details] [diff] [review]:
-----------------------------------------------------------------

Did I really write that, and forget to start calling the getElement op?

Anybody need some fresh egg?  Slightly-used, but still fresh?

Comment 4

[Boris Zbarsky [:bzbarsky]]

> Help what?

Performance, sorry.  Instead of converting uint32 to jsid and then calling the jsid ops and then checking to see whether the jsid is an int and branching on that, etc, this patch just directly calls the op taking a uint32, which arraylikes tend to fast-path.

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce40bde00ef8

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ce40bde00ef8