699706 - Scroll open tab into view when the tab list is opened

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Kevin Brosnan [Ex-Mozilla]]

When opening the tab bar your current tab is noted by being bold. Clicking on the tab drop down may not display the currently selected tab if you have more than 9 tabs open in portrait mode or 5 tabs in landscape on my g2.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

The tabs list is scrolled to the selected tab when showed first.
The tabs list still scrolls to top -- which will be fixed as a part of Bug 697098.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 572993 [details] [diff] [review]
Patch


>diff --git a/embedding/android/TabsTray.java b/embedding/android/TabsTray.java

>+        public int getSelectedTabPosition() {
>+            if (mTabs == null)
>+                return -1;
>+
>+            return mTabs.indexOf(Tabs.getInstance().getSelectedTab());
>+        }

Let's be a little more generic here:

getPositionForTab(Tab tab) {
    ...
    return mTabs.indexOf(tab);
}

r+ otherwise. I can change on checkin

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/projects/birch/rev/64ec37a61326

Comment 4

[Camelia Urian]

Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111108 Firefox/10.0a1 Fennec/10.0a1 - Native Fennec build
Device: HTC Desire Z - Android 2.3

The tabs list is scrolled to the selected tab when showed first., verified in both landscape and portrait.

Comment 5

[Wesley Johnston (:wesj)]

These patches were backed while investigating Talos failures.  Now that tests are green again, we will need to reland.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547

Comment 7

[Camelia Urian]

Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111114 Firefox/10.0a1 Fennec/10.0a1 - Native Fennec build
Device: HTC Desire Z - Android 2.3

The tabs list is scrolled to the selected tab when showed first., verified in both landscape and portrait.