Closed
Bug 699736
Opened 13 years ago
Closed 13 years ago
IM: NOTENEW indicator
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
INVALID
People
(Reporter: cdleary, Assigned: cdleary)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.52 KB,
patch
|
Details | Diff | Splinter Review |
There's no up-front indicator of the stacky start of a JSOP_NEW like there is JSOP_CALL* for JSOP_CALL. We already annotate every argument to a call with a bytecode, so this patch just adds one to indicate the start of a new expression -- this makes it possible to track opened calls as a stack.
Attachment #571905 -
Flags: review?(dvander)
|
Assignee | |
Comment 1•13 years ago
|
||
Forgot the null NOTENEW handling in the IonBuilder to prevent aborts!
Attachment #571905 -
Attachment is obsolete: true
Attachment #571905 -
Flags: review?(dvander)
Attachment #571907 -
Flags: review?(dvander)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 571907 [details] [diff] [review] NOTENEW Oh noes, I just found that |null()| just pushes null and calls it, so calls are not as book-endy as I thought they were. Need to re-evaluate this approach.
Attachment #571907 -
Flags: review?(dvander)
This could be a reason for making decisions at the point of the call, rather than the callee push.
|
|
Assignee | |
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•