699742 - battery.level should be a double

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

The specs required a float but a double seems better.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Part A - Change in DOM code

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Part B - Change in hal code

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Part C - Change in upower backend

Comment 4

[Mounir Lamouri (:mounir)]

Attachment: Part D - Change in android backend

It happens that Android backend level always has 2 digits after the comma (with my phone) but it's better to use a double given that it doesn't cost a lot and some Android versions/implementations might have a more precise value.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 572421 [details] [diff] [review]
Part A - Change in DOM code

Review of attachment 572421 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #0)
> The specs required a float but a double seems better.

Why is that?  So that it fits the natural JS value representation?

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

The code all looks fine.

Comment 8

[Mounir Lamouri (:mounir)]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #6)
> (In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #0)
> > The specs required a float but a double seems better.
> 
> Why is that?  So that it fits the natural JS value representation?

Yes.

Comment 9

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

OK.

Comment 10

[Mounir Lamouri (:mounir)]

Comment on attachment 572421 [details] [diff] [review]
Part A - Change in DOM code

This has just landed in mozilla-inbound. Requesting aurora approval for API completeness in Firefox 10. It would be better to ship Firefox 10 with the entire API if we say it is present. The risk is very low given that there is no use of the API for the moment.

Comment 11

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/ebe48efe95c5
https://hg.mozilla.org/mozilla-central/rev/538d80f3cf0e
https://hg.mozilla.org/mozilla-central/rev/08f0c3b98c52
https://hg.mozilla.org/mozilla-central/rev/090456585da8

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 572421 [details] [diff] [review]
Part A - Change in DOM code

It looks like this feature wasn't ready for 10. Please re-nominate if you have a good justification for trying to get this into 10 rather than just waiting for 11.